Changeset 134

Timestamp:

04/15/06 15:30:39 (3 years ago)

Author:

michiel

Message:

Get rid of useles exec call.

Re #56

Files:

• trunk/common/functions_blog.php (modified) (1 diff)

trunk/common/functions_blog.php

@@ -326 +326 @@
 //--------------------------------------------------------
 function blog_show_styleswitcher() {
-        exec("ls style", $dirindex);
-        foreach ($dirindex as $v) {
-                if (is_dir("style/".$v) && file_exists("style/".$v."/index.css")) {
-                        $stylename[] = $v;
-                }
-        }
-        if (count($stylename)) {
-                ?>
-                <select name="styleswitchselect" id="styleswitchselect" onchange="switchstyle();">
-                        <? foreach ($stylename as $v) { ?>
-                                <? if ($v == $_SESSION["style"]) { $selected="selected=\"selected\""; } else { $selected=""; } ?>
-                                <option value="<?=$v?>" <?=$selected?>><?=$v?></option>
-                        <? } ?>
-                </select>
-                <script language="Javascript1.2" type="text/javascript" src="common/js/styleswitcher.js"></script>
-                <?
+        if ($dh = opendir("style")) {
+                while (false !== ($v = readdir($dh))) {
+                        if (is_dir("style/".$v) && file_exists("style/".$v."/index.css")) {
+                                $stylename[] = $v;
+                        }
+                }
+                if (count($stylename)) {
+                        ?>
+                        <select name="styleswitchselect" id="styleswitchselect" onchange="switchstyle();">
+                                <? foreach ($stylename as $v) { ?>
+                                        <? if ($v == $_SESSION["style"]) { $selected="selected=\"selected\""; } else { $selected=""; } ?>
+                                        <option value="<?=$v?>" <?=$selected?>><?=$v?></option>
+                                <? } ?>
+                        </select>
+                        <script language="Javascript1.2" type="text/javascript" src="common/js/styleswitcher.js"></script>
+                        <?
+                }
+        } else {
+                return false;
         }
 }